#99 ✓out-of-date
Simon Rozet

[PATCH] Sinatra support

Reported by Simon Rozet | December 24th, 2008 @ 07:55 PM

I think I managed to fix support and #basic_auth for Sinatra.

See my sinatra branch at http://github.com/sr/webrat/tree...

I am a complete stranger to Webrat's codebase so... anyway, let me know what you think. I am available on #webrat as sr

Oh and I had lots of spec failing... is it an issue with my setup or ...?

Comments and changes to this ticket

  • Simon Rozet

    Simon Rozet December 25th, 2008 @ 04:57 PM

    Please don't pull. I am currently trying something else. I felt like I was trying to re-do what Sinatra's test helpers are doing: creating a Rack::MockRequest. So, I'll try to see if I can improve webrat/rack and then build webrat/session from there

  • Simon Rozet

    Simon Rozet December 26th, 2008 @ 12:47 PM

    I just pushed initial version of an improved RackSession :

    rack-session branch on my fork

    This only has spec and implementation for GET at the moment. Also, I am not very familiar with Rack's specification, so there might be huge mistake. (and it lakes support for redirect following)

    But now, look at how simple is SinatraSession :

    
    class SinatraSession < RackSession #:nodoc:
      def initialize(app=Sinatra.build_application)
        @app = app
      end  
    end
    

    (available in my rack-session-sinatra branch on my fork

    Let me know what you thing.

  • Bryan Helmkamp

    Bryan Helmkamp January 4th, 2009 @ 10:19 PM

    • Assigned user changed from “Bryan Helmkamp” to “Josh Knowles”
  • Josh Knowles

    Josh Knowles January 4th, 2009 @ 10:43 PM

    • State changed from “new” to “out-of-date”

    Hey Simon,

    I'm going to close this for now, but can you take a look at the latest master and let me know if there is anything else that needs to be added to support Sinatra. As far as I know everything is now passing on Integrity.

    Thanks!

    Josh

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

Referenced by

Pages