Webrat Webrat

Comments and changes to this ticket

• 

  Simon Rozet December 25th, 2008 @ 04:57 PM

  Please don't pull. I am currently trying something else. I felt like I was trying to re-do what Sinatra's test helpers are doing: creating a Rack::MockRequest. So, I'll try to see if I can improve webrat/rack and then build webrat/session from there

• 

  Simon Rozet December 26th, 2008 @ 12:47 PM

  I just pushed initial version of an improved RackSession :

  rack-session branch on my fork

  This only has spec and implementation for GET at the moment. Also, I am not very familiar with Rack's specification, so there might be huge mistake. (and it lakes support for redirect following)

  But now, look at how simple is SinatraSession :

  
  class SinatraSession < RackSession #:nodoc:
    def initialize(app=Sinatra.build_application)
      @app = app
    end  
  end
  

  (available in my rack-session-sinatra branch on my fork

  Let me know what you thing.

• 

  Bryan Helmkamp January 4th, 2009 @ 10:19 PM

  • Assigned user changed from “Bryan Helmkamp” to “Josh Knowles”

• You flagged this item as spam.
  

  Josh Knowles January 4th, 2009 @ 10:43 PM

  • State changed from “new” to “out-of-date”

  Hey Simon,

  I'm going to close this for now, but can you take a look at the latest master and let me know if there is anything else that needs to be added to support Sinatra. As far as I know everything is now passing on Integrity.

  Thanks!

  Josh