Field.to_param should check to see if Merb is defined before parsing query parameters
Reported by rbpandey | November 17th, 2008 @ 03:50 PM
I changed the else block to an elsif for Merb query param parsing. I also added a dumb else block to just return the key_and_value local variable.
def to_param
return nil if disabled?
key_and_value = "#{name}=#{escaped_value}"
if defined?(CGIMethods)
CGIMethods.parse_query_parameters(key_and_value)
elsif defined?(ActionController::AbstractRequest)
ActionController::AbstractRequest.parse_query_parameters(key_and_value)
elsif defined?(::Merb)
::Merb::Parse.query(key_and_value)
else
key_and_value
end
end
Comments and changes to this ticket
-
Bryan Helmkamp November 18th, 2008 @ 08:49 PM
- State changed from “new” to “resolved”
(from [df9d8179c0d8ed2061c5f91a9dd55d8c86fc5e26]) Field#to_param should return a hash when Merb is not defined for Mechanize support [#62 state:resolved] http://github.com/brynary/webrat...
-
-
Bryan Helmkamp December 15th, 2008 @ 02:34 PM
- State changed from “resolved” to “open”
-
gaffo June 3rd, 2009 @ 10:12 AM
- Tag set to “bug, featurerequest, stale”
rbpandey,
It's been quite a while, is this still an issue? If so could you supply an updated patch that I can take a look at?Thanks
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Ruby Acceptance Testing for Web applications.
People watching this ticket
Bryan Helmkamp
gaffo
Attachments
Tags
Referenced by
-
62
Field.to_param should check to see if Merb is defined before parsing query parameters
(from [df9d8179c0d8ed2061c5f91a9dd55d8c86fc5e26]) Field#t...