Webrat Webrat

Comments and changes to this ticket

• 

  Bryan Helmkamp November 13th, 2008 @ 11:38 PM

  How would you like to configure this? An environment variable, a webrat config block in spec_helper.rb, or some other way?

• 

  gaffo November 13th, 2008 @ 11:45 PM

  I was going to ask you that actually.

  I think a config block that can go in either spec_helper.rb or test_helper.rb would work well (I'm actually tied to test::unit). This could be flipped however the developer wanted.

  I have actually been wondering about some type of config that would allow developers to easily switch modes for webrat from standard to selenium to watir. I think somthing like that would cover it.

  Using an environment variable for this seems like it will get very verbose very quickly with all of the possible options.

• 

  gaffo November 13th, 2008 @ 11:54 PM

  Dang, my typing is atrocious. Long and short:

  Environment Variables: Would work but will bloat quickly.

  Config Block: Will likely work quite well in most cases. Also, will be more flexible later for other options.

• 

  Bryan Helmkamp November 16th, 2008 @ 06:52 PM

  • State changed from “new” to “resolved”

  (from [7460c85655fa4c6682f8e7b286f02a773b4c44c4]) [#33 state:resolved] added a configuration object that is configurable by a block http://github.com/brynary/webrat...

• 

  Bryan Helmkamp November 16th, 2008 @ 06:52 PM

  (from [58cbf49119f87f0fb483b34c26dcb80a800a4c41]) [#33 state:resolved] refactored to move the config down to Webrat::Core as it seemed nicer http://github.com/brynary/webrat...

• 

  Bryan Helmkamp November 16th, 2008 @ 06:52 PM

  (from [19353b507b90482f9ef4118baddf455712d5cc72]) Revert "[#33 state:resolved] refactored to move the config down to Webrat::Core as it seemed nicer"

  This reverts commit 58cbf49119f87f0fb483b34c26dcb80a800a4c41. http://github.com/brynary/webrat...

• 

  Bryan Helmkamp November 16th, 2008 @ 07:01 PM

  Thanks for the patch! I've merged in your branch.

  I like the configuration block approach. We'll probably be adding some more settings as the Webrat Selenium support becomes more baked and for other enhancements.

  Cheers,

  -Bryan