Unify click_button for selenium
Reported by Matthias Marschall | May 27th, 2009 @ 08:09 AM
the locator for click_button in selenium mode only supports a subset of the core locator.
My patch tries to unify both locators so that click_button works similar in both modes.
I tested all variants manually due to broken integration test support for rails/selenium.
Comments and changes to this ticket
-
gaffo May 28th, 2009 @ 07:15 PM
- Tag changed from “click_button, patch, selenium” to “click_button, patch, selenium, test!, verify”
- State changed from “new” to “open”
Matthias,
It be great if you could submit some of the integration tests even if they're not running overall. The idea is that almost everything works well in both areas. I'm currently working with something similar at my own job and when I get to this issue I'll likely verify your patch and pull it in.Thanks!
-
Larry Diehl May 29th, 2009 @ 02:52 AM
I got the Rails Selenium integration tests runnable again:
http://github.com/larrytheliquid/webrat/commit/627913708c563f136f17...Also got the existing integration test passing for click_link with id:
http://github.com/larrytheliquid/webrat/commit/4d05a2cf2b2de34dda0a...The second commit here is not as extensive as Matthias's but at least the spec <-> code ration is 1<->1.
-
Larry Diehl May 29th, 2009 @ 04:01 AM
Wups... this is for click_button, not click_link.
Should I create a separate ticket for click_link? Either way this reminded me to also make click_link work with title under selenium:
http://github.com/larrytheliquid/webrat/commit/aaa72732ada3d5f753b0... -
gaffo May 29th, 2009 @ 10:47 AM
- State changed from “open” to “awaiting-merge”
Wow, Thanks for all of that work. Hopefully I'll be able to pull in soon.
-
Bryan Helmkamp May 29th, 2009 @ 08:25 PM
- State changed from “awaiting-merge” to “resolved”
(from [0394a1fc1534d684c9ea85348339804977efa0ab]) [#254 state:resolved] Added attribution http://github.com/brynary/webrat/commit/0394a1fc1534d684c9ea8534833...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Ruby Acceptance Testing for Web applications.
People watching this ticket
gaffo
Attachments
Tags
Referenced by
-
221
webratlink locator for selenium does not find links by id or name
I added a fix for this with tests too, see the the commen...
-
236
click_button doesn't click the button element in Selenium mode
I believe #254 fixes this. If not please message and we'l...
-
254
Unify click_button for selenium
(from [0394a1fc1534d684c9ea85348339804977efa0ab])
[#254
s...