Webrat Webrat → 0.4.5

Comments and changes to this ticket

• You flagged this item as spam.
  

  diabolo March 13th, 2009 @ 12:10 PM

  actual commits are listed below

  first adds tests for title

  http://github.com/diabolo/webrat...

  second adds functionality for classes

  http://github.com/diabolo/webrat...

• You flagged this item as spam.
  

  diabolo April 21st, 2009 @ 01:27 PM

  • Assigned user set to “Bryan Helmkamp”

  This has been submitted for about a month now. Is there any reason its being ignored?

• 

  gaffo April 22nd, 2009 @ 01:22 PM

  • Tag changed from “click_link” to “click_link, patch, pull, verify”
  • State changed from “new” to “open”

  first branch looks good.

• 

  gaffo April 22nd, 2009 @ 01:36 PM

  2nd branch looks fine as well. The question is does it align with the api for the other modes.

• 

  Bryan Helmkamp April 22nd, 2009 @ 04:42 PM

  • State changed from “open” to “wontfix”

  Hey Andew,

  Sorry for the delay. I do not want to expand the current click_link API to support more location strategies implicitly, but I'd like to support this with another API.

  Here's what I'm thinking:

  
  click_link link_with_css(".class_name")
  

  Not a huge fan of the duplication of "link" but that's the best I've got so far.

  Can you please open a ticket about adding a method to lookup a link by CSS if that's useful to you, so we can track it separately? Thanks.

  Cheers,

  -Bryan

• You flagged this item as spam.
  

  diabolo April 23rd, 2009 @ 11:37 AM

  Couldn't you accept these patches and then decide to refactor the api afterwards? The patches do work, have been tested and are useful (been used in our current project for a while). In the meantime the new api doesn't exist yet. When you decide what this new api is I'm sure you can then refactor to get things just how you want them

• You flagged this item as spam.
  

  Lee Hambley April 23rd, 2009 @ 11:40 AM

  I can't see the case for not including the patch, although the prospect of reliable CSS selectors to do this sort of work are exciting, but it is leaving us all hanging a bit those of us who have had to fork webrat, and can't benefit from master changes without a load of grief keeping up to date could really use this patch.

  On what grounds are you not thinking of including this in the main distribution?

• You flagged this item as spam.
  

  Lee Hambley April 23rd, 2009 @ 11:45 AM

  Also it strikes me that link_with_css is a silly name, why not something like the following

  
  
  click_link 'Shopping Cart' # Behaves as it does presently
  
  click_link :class => 'shopping_cart'  # Class Selector `.shopping_cart`
  click_link :class => '.shopping_cart' # As Above.
  
  click_link :id => 'shopping_cart_1'  # ID Selector
  click_link :id => '#shopping_cart_1' # ID Selector
  
  click_link :href => '/cart/item/\d+' # Select anything that matches that pattern
  
  

  Just a thought, that is what my implementation went...

• 

  gaffo April 23rd, 2009 @ 01:53 PM

  One of the things we want to avoid is having to deprecate apis. Pulling in the patch as it is would require us to do so. Having a stable and standard api for webrat across all of the drivers and application frameworks has been a major goal for the last year.

• 

  gaffo April 23rd, 2009 @ 01:59 PM

  • Milestone set to “0.4.5”
• 

  gaffo April 23rd, 2009 @ 01:59 PM

  changed the milestone just for the tests. no problem changing it back if this is confusing.

• You flagged this item as spam.
  

  KomiKomi November 14th, 2021 @ 05:35 AM

  An excellent and very helpful forum! Thank you for sharing useful information! I also want to share something useful with you! You can try this out if you want to get rid of mistakes in the text, make it better and more professional. The tool specializes in active voice, and with the help of special algorithms it helps to find it and indicates errors in it. Also, the tool is able to independently generate an active voice and integrate it into the text. It is very simple and convenient, especially when there is no time to check.

• You flagged this item as spam.
  

  Hassanraza78678690 July 2nd, 2022 @ 09:32 AM

  great amazing https://statusluv.com/