#188 Fix for missing quote in save_and_open_page - Webrat

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#188 ✓resolved

Fix for missing quote in save_and_open_page

Reported by Erin Staniland | March 6th, 2009 @ 11:17 AM

The regular expression in rewrite_css_and_image_references is missing a quote in the replacement. The attached patch fixes this. I've also added support for single quotes.

I've attached a patch or you can pull my change from github http://github.com/erino/webrat/c...

Comments and changes to this ticket

gaffo May 7th, 2009 @ 04:34 PM
- State changed from “new” to “awaiting-merge”
Have not verified the patch applies, but otherwise it looks good.
You flagged this item as spam.
Erin Staniland May 8th, 2009 @ 07:04 AM
I just tried attaching the path to master and it failed. So here's an updated version which does.
- 0001-Added-missing-quote-from-rewrite_css_and_image_refer.patch 2.2 KB
Bryan Helmkamp June 14th, 2009 @ 09:01 PM
- State changed from “awaiting-merge” to “resolved”
Thanks for the patch, Erin.

Applied. http://github.com/brynary/webrat/commit/b75ff6221b60361cdcd6ab43dfa...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.