#161 UrlEncodedPairParser removed in edge rails - Webrat

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#161 ✓resolved

UrlEncodedPairParser removed in edge rails

Reported by nkryptic | February 11th, 2009 @ 07:21 AM

rails commit 2277fbed removes UrlEncodedPairParser. The params parser is now moved to rack middleware. This causes webrat (as of commit 24eab77ecda6) to fail on it's to_param method when trying to resolve rails_request_parser in webrat/lib/webrat/core/elements/field.rb.

Comments and changes to this ticket

gaffo February 11th, 2009 @ 06:20 PM
- Tag set to “edge, verified”
- State changed from “new” to “open”
- Assigned user set to “gaffo”
I'm looking into it right now.
gaffo February 11th, 2009 @ 06:35 PM
Not sure that there are any tests covering this. I'm going to attach a patch for the fix but I'm not going to push it. Could someone please help me verify that it's the correct patch?
- lh_161.diff 1.3 KB
You flagged this item as spam.
Josh Knowles February 16th, 2009 @ 06:36 PM
Looks correct. That said it would be nice to get a Rails 2.3 app in the integration test suite to help verify this kind of thing.
gaffo February 16th, 2009 @ 06:48 PM
So that's the question. Does webrat edge support latest release of rails / merb / sinatra? or does it support edge of each ?

Or does it support both?
gaffo February 16th, 2009 @ 06:49 PM
We wouldn't have to put an actual different app into the integrations most of the time. We could just have a switch based upon environment in the environment.rb file which said RAILS_VERSION = XXX depending. So either release or edge in there.
gaffo February 16th, 2009 @ 06:50 PM
- State changed from “open” to “awaiting-merge”
You flagged this item as spam.
Kenneth Kalmer February 17th, 2009 @ 04:54 PM
Please check out http://github.com/dchelimsky/rsp... on a better way to parse the params with Rack.

The current patch over-zealously escapes form values.
You flagged this item as spam.
Sven Fuchs February 20th, 2009 @ 03:49 PM
Kenneth, that doesn't work for me either. Nested params aren't parsed into a nested Hash.

Rack has a parse_nested_query method that seems to work here:

Rack::Utils.parse_nested_query(params)
You flagged this item as spam.
matthewcford February 26th, 2009 @ 09:45 AM
I've incorporated the patch with Rack::Utils. parse_nested_query, into my branch and it seems to work for me:

http://github.com/matthewford/we...
Bryan Helmkamp March 7th, 2009 @ 08:01 PM
- State changed from “awaiting-merge” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.