Webrat Webrat → 0.4.2

There is a bug in link#absolute_href:

54 def absolute_href 55 if href =~ /^\?/ 56 "#{@session.current_url}#{href}" 57 elsif href !~ %r{^https?://www.example.com(/.*)} && (href !~ /^\//) 58 "#{@session.current_url}/#{href}" 59 else 60 href 61 end 62 end

I'm not positive, but I think Line 55 should be:

if href =~ /^\/?/

unless it's meant to be checking for urls that begin with '?'? If so, it would turn ?foo into 'http://foo.bar.baz?foo', which I'm not sure is legal.

Line 57 should not check for the existence of www.example.com, as that causes it to fail on absolute urls. Assuming that I'm right about line 55, it should also not check that href is a relative url, as it can never be reached if it is:
elsif href !~ %r{^https?://[^/]+(/.*)}