#132 ✓resolved
Adam greene

[patch] remove vestiges of normalizing rails urls before action

Reported by Adam greene | January 16th, 2009 @ 03:16 PM | in 0.4.1

hey guys,

Here is my use case. with my previous patch on internal_redirect? ignoring subdomains, the fact that #do_request strips out host information becomes an issue. My app, as well as many others I imagine, will redirect users to their appropriate subdomain if they aren't in it, but if the host information is stripped then my app keeps seeing the old host and it goes into an infinite redirecting loop.

I imagine this logic was there to try and work around the redirecting issue, but now that I think Josh came up with a nice solution for that, I suggest that this logic is removed.

If our belief is that testing frameworks should emulate the 'real world' as much as possible, then normalizing url's does not do us any favors.

Please let me know if you have questions. Thanks, Adam

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

People watching this ticket

Pages