#370 Patch - add flie and line to eval block - Webrat

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#370 ✓resolved

Patch - add flie and line to eval block

Reported by Alex Chaffee | March 23rd, 2010 @ 02:51 PM

If an exception is thrown during the evaluation of a proxied method inside Webrat::Methods, the stack trace just says "(eval):2:in select". This patch adds the file and line number so poor clients can tell that it's happening inside webrat and where.

diff --git a/lib/webrat/core/methods.rb b/lib/webrat/core/methods.rb
index 7c0788d..639fd3e 100644
--- a/lib/webrat/core/methods.rb +++ b/lib/webrat/core/methods.rb @@ -3,7 +3,7 @@ module Webrat

 def self.delegate_to_session(*meths)
   meths.each do |meth|

```
 self.class_eval <<-RUBY
```

 self.class_eval(<<-RUBY, __FILE__, __LINE__)
   def #{meth}(*args, &blk)
     webrat_session.#{meth}(*args, &blk)
   end

Comments and changes to this ticket

You flagged this item as spam.
Alex Chaffee March 23rd, 2010 @ 03:26 PM
Oy, looks like the formatting blew up the patch. I'll attach a patch file.
- class_eval_patch.txt 454 Bytes
Damian Janowski April 12th, 2010 @ 04:47 PM
- Tag set to “to_be_closed”
Fixed on master. http://github.com/brynary/webrat/commit/0bbf163d4ff258eb8a4d0cd75a3...
Damian Janowski April 12th, 2010 @ 08:55 PM
- Tag cleared.
- State changed from “new” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.