#319 ✓resolved
Larry Marburger

Core::Session#redirect? thinks a 304 is a redirect

Reported by Larry Marburger | January 9th, 2010 @ 11:11 AM

While writing a scenario that sets an If-Modified-Since header to test that a 304 Not Modified is returned, I quickly discovered that #redirect? thinks any response in the 300 range is a redirect. Here's my quick and dirty commit that explicitly ignores 304s.

http://github.com/lmarburger/webrat/commit/85cd5eeb51e83daacc2664b6...

Perhaps a more correct approach would be something along the lines of [ 300, 301, 302, 303, 307 ].include? response_code

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

People watching this ticket

Pages