#249 Select field Ruby 1.9.1 incompatibility - Webrat

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#249 ✓resolved

Select field Ruby 1.9.1 incompatibility

Reported by qoobaa | May 26th, 2009 @ 04:42 AM

Params for default options in select look like:

{ "birthdate(1i)"=>"[\"1955\"]", "birthdate(2i)"=>"[\"5\"]", "birthdate(3i)"=>"[\"8\"]" }

It's caused by using to_s on an Array object. Be aware of using to_s method guys.

0001-fixed-escaped_value-to-use-join-instead-of-to_s.patch 772 Bytes

Comments and changes to this ticket

gaffo May 28th, 2009 @ 07:07 PM
- Tag changed from “bug, field, patch” to “bug, field, patch, test!, verify”
- State changed from “new” to “awaiting-patch”
Can you please add a test to show what this is fixing?
You flagged this item as spam.
qoobaa May 29th, 2009 @ 03:26 AM
It fixes 8 of 13 broken specs in current repository. Do you still need another one?
You flagged this item as spam.
qoobaa May 29th, 2009 @ 03:28 AM
- Tag changed from “bug, field, patch, test!, verify” to “bug, field, patch, test!, tested, verify”
gaffo May 29th, 2009 @ 10:50 AM
- Tag changed from “bug, field, patch, test!, tested, verify” to “bug, field, patch, verify”
Just clarifying, you mean its fixing 8 tests that are currently broken under 1.9.1? If so that would be plenty of reason.

Do you have a good reference on how to get 1.9.1 to coincide with a 1.8.7 on linux? That would help me verify and pull this in faster.

Thanks again!
gaffo May 29th, 2009 @ 10:50 AM
- State changed from “awaiting-patch” to “awaiting-merge”
You flagged this item as spam.
qoobaa May 29th, 2009 @ 02:11 PM
You can have Ruby 1.9.1 in /usr/local with suffix 1.9 (check the ./configurate options). There're 5 tests that don't pass. Some of the problems are related with Mechanize Ruby 1.9.1 incompatibility.
Bryan Helmkamp June 14th, 2009 @ 09:06 PM
- State changed from “awaiting-merge” to “resolved”
(from [8b98540aef3f3a6b353bc8c7fa655181c6947ce7]) Ruby 1.9 compatibility: Avoid calling #to_s on Arrays

[#249 state:resolved] http://github.com/brynary/webrat/commit/8b98540aef3f3a6b353bc8c7fa6...
Bryan Helmkamp June 14th, 2009 @ 09:06 PM
Thanks for the patch, Jakub. Applied.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins (Sort)

↓↑ drag 308 Open Bugs
↓↑ drag 32 Open Patches
↓↑ drag 26 Open Feature Requests

People watching this ticket

Attachments

0001-fixed-escaped_value-to... 772 Bytes

Referenced by

249 Select field Ruby 1.9.1 incompatibility [#249 state:resolved] http://github.com/brynary/webrat/c...

Webrat Webrat