#226 ✓wontfix

not waiting for page load with selenium

Reported by barunio | April 20th, 2009 @ 03:22 PM | in 0.4.2

in my app, this fails:

def login_as(user, password)
  visit new_session_path
  fill_in "username", :with  => user.username
  fill_in "password", :with => password
  response.body.should =~ /Signed in as #{user.username}/

but this works:

def login_as(user, password)
  visit new_session_path
  fill_in "username", :with  => user.username
  fill_in "password", :with => password
  response.body.should =~ /Signed in as #{user.username}/

webrat isn't appropriately waiting for a new page to load before executing the next step. i am using version 0.4.4

just for reference, this is related to an earlier email sent on the rspec mailing list: http://www.nabble.com/-cucumber-...

Comments and changes to this ticket

  • gaffo

    gaffo April 22nd, 2009 @ 12:41 PM

    did you update your selenium client?

  • gaffo

    gaffo May 7th, 2009 @ 07:00 PM

    • Tag changed from selenium, wait_for to selenium, stale, wait_for
  • gaffo

    gaffo May 7th, 2009 @ 07:00 PM

    • State changed from “new” to “open”
  • gaffo

    gaffo June 3rd, 2009 @ 10:10 AM

    Which version of selenium client do you have installed? gem list | grep selenium-client


  • gaffo

    gaffo June 4th, 2009 @ 07:23 PM

    I've noticed this a bit as well. I have some timing issues when I try to get response.body.

    The issue is that selenium takes a tiny little bit (which grows as the machine gets slower) to update the response.body after each invocation.

    There are a few options here, I'm currently doing:

    automate do
    selenium.wait_for_page_to_load end

    before tests that are failing for this reason.

    What we would like to do is move some of these asserts into javascript and have selenium execute them. This would remove the timeout. Then you could do assert_xpath / etc.

    I'm open to suggestions on what we can do to make it wait better but don't really know how to solve it other than that at the moment.

  • gaffo

    gaffo June 4th, 2009 @ 08:07 PM

    def click_button(button_text_or_regexp = nil, options = {})

      if button_text_or_regexp.is_a?(Hash) && options == {}
        pattern, options = nil, button_text_or_regexp
      elsif button_text_or_regexp
        pattern = adjust_if_regexp(button_text_or_regexp)
      pattern ||= '*'
      locator = "button=#{pattern}"
      selenium.wait_for_element locator, :timeout_in_seconds => 5
      selenium.click locator

    it waits until it can find teh locator or for 5 seconds. or it fails.

    We're actually discussing some of this stuff in the irc channel.

  • gaffo

    gaffo June 5th, 2009 @ 03:07 PM

    Yes. I thought you were railing on the response.body.should =~ /Signed in as #{user.username}/


    If so, then it will click, wait, and then go on. Correct?

  • Amos King

    Amos King June 8th, 2009 @ 11:34 AM

    Asserting that something is not on the page seems like a bad idea anyway. If I say that "Bob" is not there, and "bob" is on the page then it still won't fail. At least saying something is there will fail if it isn't exact. Saying it is not there is far more dependent on the exact format showing up to fail.

  • gaffo

    gaffo June 8th, 2009 @ 12:06 PM

    • State changed from “open” to “wontfix”
    • Milestone set to 0.4.2

    I think in this case we have to leave it up to the developer to put the right wait in. If it's an ajax link, you need to wait_for_ajax right after the click. If it's a normal link, wait_for_page.

    I can't really think of anything that is more clever that won't fail or slow things down in a different fashion for all of the reasons listed above.

    I'm going to close this ticket as won't fix unless we can come up with a better option. Sorry, and thanks for the feedback.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

Referenced by