#210 open
_Kevin

form.submit inappropriately escapes field values

Reported by _Kevin | March 29th, 2009 @ 11:38 AM

after using fill_in to populate a field with an email address: "nowhere@nowhere.com".

On submission, the server gets:

"nowhere%40nowhere.com"

The live form results in "nowhere@nowhere.com" being submitted.
(this was a post request, FYI).

Comments and changes to this ticket

  • gaffo

    gaffo May 7th, 2009 @ 05:07 PM

    • Tag set to form, verify, webrat
    • State changed from “new” to “open”
  • gaffo

    gaffo June 3rd, 2009 @ 10:08 AM

    Corey, that Gist is gone could you repost or attach here?

  • gaffo

    gaffo June 12th, 2009 @ 12:09 AM

    • Assigned user changed from “Bryan Helmkamp” to “gaffo”
    • State changed from “open” to “awaiting-patch”

    Corey,
    Thanks for the patch. It'll help me to pull it in easier if you can put in a spec that shows the problem and then a commit that fixes it. I know it's annoying but things like that speed my job up. With a patch and a test it becomes a simple run without fix, yeah, that's wrong, run with test, yep that fixes it and everythign else passes. Without, well it just makes it harder.

    I'd appreciate it if you could. I'll get to it when I can if not. I know how things go. Just trying to help us both.

    -Mike

  • Damian Janowski

    Damian Janowski June 23rd, 2009 @ 08:56 PM

    • Tag changed from form, verify, webrat to form, patch, verify, webrat
  • gaffo

    gaffo June 23rd, 2009 @ 09:30 PM

    • State changed from “awaiting-patch” to “awaiting-merge”

    Need to verify and pull in but looks good at first look.

  • Simon Rozet

    Simon Rozet June 24th, 2009 @ 12:50 PM

    • Assigned user changed from “gaffo” to “Simon Rozet”
    • State changed from “awaiting-merge” to “hold”

    I've merged it back into my local 'rack' branch; please hold on until it is merged in master. Consider I am taking care of this :)

  • gaffo

    gaffo June 24th, 2009 @ 01:11 PM

    Simon,
    Are you keeping track of what tickets you need to close out when you finally merge your branch back in? Might be a good idea to either track in history or in the lighthouse ticket for the rack test.

  • Simon Rozet

    Simon Rozet June 24th, 2009 @ 06:43 PM

    Not yet. I'll get through the tickets and assign to myself those related to rack ASAP

  • Simon Rozet

    Simon Rozet June 24th, 2009 @ 06:55 PM

    • State changed from “hold” to “open”
    • Tag changed from form, patch, verify, webrat to form, patch, rack, webrat

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

Pages