#190 Sinatra sessions do not persist - Webrat

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#190 open

Sinatra sessions do not persist

Reported by Ben Mabey | March 9th, 2009 @ 02:10 PM

I was using the standard Sinatra sessions (which are based on rack cookies, I believe) and I could not get webrat to persist them.

I'll come up with a simple example to verify the problem actually exists.

Comments and changes to this ticket

You flagged this item as spam.
Joe Ferris April 1st, 2009 @ 09:37 PM
I wrote a test case and fix for cookies in Sinatra apps, which also fixes the session persistence issue: http://github.com/jferris/webrat...
gaffo May 7th, 2009 @ 06:27 PM
- Tag changed from “sinatra” to “sinatra, verify”
- State changed from “new” to “awaiting-merge”
needs to be verified
Damian Janowski May 12th, 2009 @ 09:04 AM
I can confirm that Joe's patch fixes the issue. Should I mark the ticket as "verified"?

Can we please get this applied?
Damian Janowski May 12th, 2009 @ 09:05 AM
The branch to pull from is this: http://github.com/jferris/webrat...
gaffo May 12th, 2009 @ 11:24 AM
Thanks Damian. Actually the "Needs to be verified" is more of an internal note for Bryan, Josh or myself that we haven't actually pulled the patch in locally and checked it out. Eg, don't just blindly apply it and push. I guess that's a bit redundant :). We have about 20 patches to pull in, it's just waiting on when Bryan, Josh or I have an hour or so to pull things in. We tend to discuss the impact of patches before applying them.
You flagged this item as spam.
Jeff Hodges May 18th, 2009 @ 10:13 AM
Hey, this doesn't seem to have made it in, yet. Can someone with commit rights please take a look at this? Or has a different implementation of it been done that I can't find in the repo?
You flagged this item as spam.
Jeff Hodges May 18th, 2009 @ 10:26 AM
Ahhh, never mind. #233 seems to be the real fix.
You flagged this item as spam.
Jeff Hodges May 18th, 2009 @ 10:27 AM
Er, #223
You flagged this item as spam.
Roland Swingler June 18th, 2009 @ 05:20 AM
There has been some discussion on the mailing list surrounding this, but no conclusions as of yet. I've attached a documentation patch that makes the current situation clearer for those reading the docs.
- 0001-Adding-information-about-sessions-being-disabled-in.patch 2.5 KB
Simon Rozet June 24th, 2009 @ 06:52 PM
- Assigned user changed from “Bryan Helmkamp” to “Simon Rozet”
- State changed from “awaiting-merge” to “hold”
- Tag changed from “sinatra, verify” to “racj, sinatra, verify”
Simon Rozet June 24th, 2009 @ 06:54 PM
- Tag changed from “racj, sinatra, verify” to “rack, sinatra”
- State changed from “hold” to “open”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.