Webrat Webrat → 0.4.2

Comments and changes to this ticket

• You flagged this item as spam.
  

  bronson April 1st, 2009 @ 03:45 AM

  I really hope JM's patch is applied. It works great for me and is very needed for people running Linux. +1!

• You flagged this item as spam.
  

  Ben Mabey April 7th, 2009 @ 10:06 PM

  Umm.. You may want to use launchy for this:

  http://github.com/copiousfreetim...

  No need for webrat to duplicate efforts when launchy will handle all the platform issues for you. Just an idea though... it is up to you on if you want to add another dependency. (FYI, the github gem uses launchy.)

• You flagged this item as spam.
  

  bronson April 18th, 2009 @ 06:20 PM

  Bryan said at gogaruco that they're going to integrate launchy to solve this.

• 

  gaffo April 22nd, 2009 @ 12:53 PM

  • State changed from “new” to “open”

  I'm in favor of pulling this in until launchy is integrated.

• You flagged this item as spam.
  

  Paul Battley June 5th, 2009 @ 12:33 PM

  I've got a better fix for this, using xdg-open instead of firefox. This should work on any modern Linux desktop and open in the user's preferred browser.

  http://github.com/threedaymonk/webrat/commit/8b583a8b71e78411185c32...

• 

  gaffo June 8th, 2009 @ 10:09 AM

  • Tag changed from “enhancement, linux, patch” to “enhancement, linux, patch, verify”
  • State changed from “open” to “awaiting-merge”
  • Milestone set to “0.4.2”

  Just need to test it out.

• You flagged this item as spam.
  

  Michael Greenly June 13th, 2009 @ 10:42 PM

  Simply using xdg-open path/to/file will cause the browser to block if it's not already running. A better approach would be to use 'sh -c "xdg-open path/to/file"' or maybe fork{xdg-open path/to/file} to run the command in it's own process.

  http://github.com/mgreenly/webrat/commit/666914f896f0735d02821c286b...

• 

  Bryan Helmkamp June 14th, 2009 @ 09:41 PM

  • State changed from “awaiting-merge” to “resolved”

  Thanks for the patches, JM, Paul and Michael.

  I've gone ahead and setup Webrat to use Launchy so that we hopefully won't have to maintain cross-platform compatible code for this:

  http://github.com/brynary/webrat/commit/d620e66bd8f4f763d2e52c1a5be...

  If you guys run into any issues with this approach, please reopen this and we'll figure out how to get them addressed.

  Cheers,

  -Bryan