Form dom's should be scoped by the 'within' blocks
Reported by Daniel Lucraft | January 12th, 2009 @ 10:10 AM | in 0.4.2
I scoped the document with a 'within' block and then pressed a button, and there was an error because the Form#dom was returning nil, even though the Form had an element that was correct.
Eventually tracked this down to the Form#path being scoped from the small sub-document, but Form#dom using @session.dom, which is the complete document. So Form#dom was returning nil.
The commit http://github.com/songkick/webrat/commit/67c9a3827bca63d38a19b45fbc...
fixes this. All webrat specs still pass, but I confess this is a slightly superstitious patch.
thanks
Dan
Comments and changes to this ticket
-
gaffo January 12th, 2009 @ 12:41 PM
- Tag changed from “bug, click_button, form, patch, within” to “bug, click_button, form, patch, test!, verify, within”
Can you please put in a spec that demonstrates the issue?
-
Bryan Helmkamp January 25th, 2009 @ 04:59 PM
- Milestone set to “0.4.1”
-
Bryan Helmkamp February 8th, 2009 @ 11:23 PM
- Milestone changed from “0.4.1” to “0.4.2”
-
gaffo May 7th, 2009 @ 03:00 PM
- State changed from “new” to “awaiting-patch”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Ruby Acceptance Testing for Web applications.
People watching this ticket
gaffo
Referenced by
-
134
Fields outside the current scope can still be found
Just noticed ticket #119 that brings this up for Form#dom.