#118 ✓resolved
Daniel Lucraft

Infinite redirects should be detected and should raise an error

Reported by Daniel Lucraft | January 12th, 2009 @ 06:23 AM

Due to bug http://webrat.lighthouseapp.com/projects/10503/tickets/117-redirect..., our Rails application was generating an infinite redirect, which caused Webrat to hang. Webrat should detect this and raise an error.

The commits

fix this. (Sorry there's two!)

Comments and changes to this ticket

  • gaffo

    gaffo January 12th, 2009 @ 12:25 PM

    • Tag changed from featurerequest, patch, request, session to featurerequest, patch, request, session, verify

    1) Could you add a spec that exercises this? 2) Could you make the INFINITE_REDIRECT_CUT into a configuration option on config.rb with a default to 10 (and an associated test)? 3) What made you pick 10? Some article or just a guess / feeling?

  • Bryan Helmkamp

    Bryan Helmkamp February 8th, 2009 @ 08:56 PM

    • State changed from “new” to “resolved”

    Hey Daniel,

    I added a couple specs, did a small refactoring and merged this in. Thanks for the patch!



Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Ruby Acceptance Testing for Web applications.

Shared Ticket Bins

People watching this ticket